[ENH] fix side effects in check_estimator
utility
#2597
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
check_estimator
utility can test estimator instances, which is useful to test specific hyper-parameter settings.Unfortunately, this had side effects on the passed estimator - which was used in testing throughout - and would break if the estimator was already fitted.
This PR fixes that issue by passing a clone and not the reference to the testing framework, in
run_tests
.