Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] upgrade the "all" modules to automatic retrieval #2845

Merged
merged 2 commits into from Jun 29, 2022
Merged

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Jun 21, 2022

This PR upgrades the all modules to automatic retrieval and export of all estimators of a certain type, and adds an all module for transformations.

Intended use is via from modulename.all import * which then loads all estimators and relevant objects (like ForecastingHorizon for forecasters) in memory.

The all modules have fallen very much out of date, current main state is perhaps around 0.7.X or 0.8.X. Part of the reason is that the extension guidelines did not list "add your estimator to the export list in the all module.
This PR also removes the need for doing that, as retrieval is automatic, via the all_estimators utility.

@fkiraly fkiraly added maintenance Continuous integration, unit testing & package distribution module:classification classification module: time series classification module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing enhancement Adding new functionality labels Jun 21, 2022
@fkiraly fkiraly added this to Should have in Release v0.14.0 Jun 25, 2022
@fkiraly fkiraly merged commit 229ced2 into main Jun 29, 2022
@fkiraly fkiraly deleted the all-modules branch June 29, 2022 09:06
@fkiraly fkiraly moved this from Should have to Done in Release v0.14.0 Jun 29, 2022
@fkiraly fkiraly moved this from Done to Must have in Release v0.14.0 Jun 29, 2022
@fkiraly fkiraly moved this from Must have to Small things, easy to fix in Release v0.14.0 Jun 29, 2022
@fkiraly fkiraly moved this from Small things, easy to fix to Done in Release v0.14.0 Jun 29, 2022
tobiasweede pushed a commit to tobiasweede/sktime that referenced this pull request Jul 5, 2022
This PR upgrades the `all` modules to automatic retrieval and export of all estimators of a certain type, and adds an `all` module for `transformations`.

Intended use is via `from modulename.all import *` which then loads all estimators and relevant objects (like `ForecastingHorizon` for forecasters) in memory.

The `all` modules have fallen very much out of date, current `main` state is perhaps around 0.7.X or 0.8.X. Part of the reason is that the extension guidelines did not list "add your estimator to the export list in the `all` module.
This PR also removes the need for doing that, as retrieval is automatic, via the `all_estimators` utility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality maintenance Continuous integration, unit testing & package distribution module:classification classification module: time series classification module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant