[ENH] test for more than one parameter sets per estimator #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
the
module:tests
This was referenced Sep 14, 2022
fkiraly
added a commit
that referenced
this pull request
Sep 21, 2022
Towards #3429. This adds a second parameter set for all estimators checked via `check_estimator` in the `no-softdeps` CI element. This is generally useful, and also allows #2862 to pass that CI element. Also fixes a bug discovered through this: `ExponentTransformer.inverse_transform` breaking if `power` is close to zero. This is now dealt with by a skip and a warning.
|
FYI @julia-kraus, the test failures point precisely to the estimators with only one test parameter set. |
fkiraly
requested review from
achieveordie,
benHeid and
yarnabrina
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to test parameter settings for estimators properly, each important parameter should have been set to a non-default.
This PR introduces a test which checks that there are at least two test parameter sets (if the estimator has at least one parameter), and correctness of these sets.
Requires:
get_test_params, and reserved parameters #4279 for the general test forget_test_params(no specific number assumed)set_paramsto callreset, to comply withsklearnparameter interface assumptions #2835 as it uses the parameter name interfaceno-softdepsstep.Current estimators are not tested due to differential testing.
If diff testing is turned off, helps tracking down the estimators that do not yet have two parameter sets, see #3429.