New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] __getitem__
aka [ ]
dunder for transformers, column subsetting
#2907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:transformations
transformations module: time series transformation, feature extraction, pre-/post-processing
enhancement
Adding new functionality
labels
Jul 1, 2022
Credit to Also see discussion here: #2654 |
8 tasks
miraep8
reviewed
Jul 6, 2022
miraep8
reviewed
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Adding new functionality
module:transformations
transformations module: time series transformation, feature extraction, pre-/post-processing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds column subsetting functionality to transformers via the
[ ]
(__getitem__
) dunder.Similar to how this works in
pywatts
, using the[ ]
dunder will change any transformer to additionally subsetting columns of outputs (first key) and/or inputs (second key).This is done by pipelining with the existing
ColumnSelect
transformer, using the existingTransformerPipeline
.Examples:
my_trafo["a"]
is shorthand forColumnSelect("a") * my_trafo
, which in turn is shorthand forTransformerPipeline([ColumnSelect("a"), my_trafo])
my_trafo[idx1, idx2]
is shorthand forColumnSelect(idx1) * my_trafo * ColumnSelect(idx2)
, which in turn is shorthand forTransformerPipeline([ColumnSelect(idx1), my_trafo, ColumnSelect(idx2)])
Includes tests.
Relies on:
ColumnSubset
to work for scalarcolumns
parameter #2906, so subsetting likemy_trafo["a"]
is valid (same asmy_trafo[["a"]]
)ThetaLinesTransformer
in a pipeline was not workingCredit to
pywatts
for the idea - thanks, @benHeid, @SMEISEN, @kalebphipps!Also see discussion here: #2654