[MNT] remove Azure build tools and dependency handling instructions #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
the
maintenance
fkiraly
added a commit
that referenced
this pull request
Jul 10, 2022
This PR moves inactive legacy code on soft dependency testing for the no longer in use Azure CI/CD to the `test_softdeps` test action on GitHub actions. Original location is in the Azure build tools, `build_tools.azure.check_soft_dependencies`. When this is moved, the legacy Azure content can probably be removed without a loss (see Pr #2917 that does this) The test code is adapted and based on the package dependency tags in PR #2915. Tests being carried out: * `_check_pyhon_version` error is raised when trying to construct an estimator requiring a python version incompatible with spces (according to tags) * `_check_soft_dependencies` error is raised when trying to import a module requiring a soft dependency that is not installed * `_check_soft_dependencies` error is raised when trying to construct an estimator requiring a soft dependency that is not installed * no `ModuleImportError`-s are encountered when trying to construct estimators without soft dependencies and compatible python version (according to tags) * no `ModuleImportError`-s are encountered when trying to construct estimators where python version is compatible and soft dependencies (according to tag) are present in the environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes Azure build tools and dependency handling, including documentation on dependency handling for Azure.
We are no longer using Azure CI/CD, so it seems like superfluous instructions for developers, and unused code, both of which can be safely removed.