[ENH] test that set_params recognizes unique suffixes as aliases for full parameter string
#2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
API design
|
Problem with the first draft: if Added tests for this. |
fkiraly
requested review from
achieveordie,
benHeid and
yarnabrina
as code owners
fkiraly
changed the title
set_params to recognize unique suffixes as aliases for full parameter stringset_params to recognize unique suffixes as aliases for full parameter string
|
hm, maybe it is best if this change is made only in |
fkiraly
added a commit
to sktime/skbase
that referenced
this pull request
Oct 25, 2023
…arameter string (#229) Mirror of sktime/sktime#2931 This PR introduces experimental functionality to `set_params` to enable it to recognize unique suffixes as aliases for full parameter strings. That is, in the example in sktime/sktime#2929, it enables `set_params` - and, in consequence, the `param_grid` of grid search - to recognize `max_depth` instead of `forecaster__forecast__estimator__max_depth`. This is primarily meant as convenience sugar for the user of grid search or, more generally, `set_params`. Contains tests for both nested parameter setting behaviour, as well as parameter key aliasing in nested composites.
fkiraly
changed the title
set_params to recognize unique suffixes as aliases for full parameter stringset_params recognizes unique suffixes as aliases for full parameter string
|
Updated this PR as the change is now in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: The logic in this PR became obsolete after merging it upstream in
scikit-base 0.6.1, seesktime/skbase#229
The PR still adds the tests in
sktime, with ascikit-baseversion condition, but does not add the logic anymore.This PR introduces experimental functionality to
set_paramsto enable it to recognize unique suffixes as aliases for full parameter strings.That is, in the example in #2929, it enables
set_params- and, in consequence, theparam_gridof grid search - to recognizemax_depthinstead offorecaster__forecast__estimator__max_depth.This is primarily meant as convenience sugar for the user of grid search or, more generally,
set_params.Contains tests for both nested parameter setting behaviour, as well as parameter key aliasing in nested composites.