Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] address shadowing of object in _check_soft_dependencies #3116

Merged
merged 3 commits into from Aug 5, 2022
Merged

[BUG] address shadowing of object in _check_soft_dependencies #3116

merged 3 commits into from Aug 5, 2022

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Jul 28, 2022

The argument object of _check_soft_dependencies was shadowing the builtin object, which is error-prone.

Replaced the argument with obj.

No deprecation needed, since this is a private utility.

@fkiraly fkiraly added module:tests test framework functionality - only framework, excl specific tests bugfix Fixes a known bug or removes unintended behavior labels Jul 28, 2022
@fkiraly fkiraly requested a review from aiwalter as a code owner July 28, 2022 09:41
@fkiraly fkiraly merged commit 7c348e2 into main Aug 5, 2022
@fkiraly fkiraly deleted the remove-shadowing branch August 5, 2022 16:48
@fkiraly fkiraly mentioned this pull request Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiwalter aiwalter Awaiting requested review from aiwalter

Assignees
No one assigned
Labels
bugfix Fixes a known bug or removes unintended behavior module:tests test framework functionality - only framework, excl specific tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fkiraly