[BUG] removes superfluous UserWarning in AutoETS.fit if auto=True and additive_only=True #3311
#3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary warning
fkiraly
changed the title
UserWarning in AutoETS.fit if auto=True and additive_only=True #3311
fkiraly
added
module:forecasting
fkiraly
changed the title
UserWarning in AutoETS.fit if auto=True and additive_only=True #3311UserWarning in AutoETS.fit if auto=True and additive_only=True #3311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unnecessary warning from ETS estimator
Reference Issues/PRs
Bug #3311
What does this implement/fix? Explain your changes.
This removes a warning about multiplicative components when self.additive_only == True
Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
Open to any feedback, this is my first open source PR
Any other comments?
I also added a space in the warning string so it will be formatted slightly better when printed. I will add myself to the list of contributors and add unit tests if necessary.
PR checklist
For all contributions