Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] replace inplace sort by non-inplace sort in Reconciler #3553

Merged
merged 1 commit into from Oct 10, 2022
Merged

[ENH] replace inplace sort by non-inplace sort in Reconciler #3553

merged 1 commit into from Oct 10, 2022

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Oct 8, 2022

Replaces inplace sort by non-inplace sort in Reconciler to avoid any inplace related issues (e.g., side effects)

@fkiraly fkiraly added maintenance Continuous integration, unit testing & package distribution module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing labels Oct 8, 2022
@fkiraly fkiraly requested a review from aiwalter as a code owner October 8, 2022 22:19
@fkiraly fkiraly mentioned this pull request Oct 9, 2022
Open
patrickzib
patrickzib approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@patrickzib patrickzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@fkiraly fkiraly merged commit 684ef5b into main Oct 10, 2022
@fkiraly fkiraly deleted the reconciler-sort branch October 10, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickzib patrickzib patrickzib approved these changes

@aiwalter aiwalter Awaiting requested review from aiwalter

Assignees
No one assigned
Labels
maintenance Continuous integration, unit testing & package distribution module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fkiraly @patrickzib