[ENH] Add test for global forecasting #3728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbartl
requested review from
fkiraly,
aiwalter and
GuzalBulatova
as code owners
fkiraly
reviewed
Nov 10, 2022
fkiraly
requested changes
Nov 10, 2022
There was a problem hiding this comment.
Looks good, good idea to make this more robust!
Above some comments, for me only the one about the commented out lines by @GuzalBulatova is blocking.
|
Thanks for the detailed review :), I addressed all points. |
GuzalBulatova
approved these changes
Nov 12, 2022
fkiraly
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the bug report for the reasoning: #3601 (comment) .
There is not a bug in the implementation, but it actually makes sense to check for this fact.