Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] added new slack link #3747

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Conversation

hadifawaz1999
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

Copy link
Collaborator

@miraep8 miraep8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@miraep8 miraep8 changed the title added new slack link [DOC] added new slack link Nov 10, 2022
@miraep8 miraep8 added documentation Documentation & tutorials bug Something isn't working labels Nov 10, 2022
@MatthewMiddlehurst
Copy link
Contributor

Both links work for me, are people having issues with the previous one?

@miraep8
Copy link
Collaborator

miraep8 commented Nov 11, 2022

@MatthewMiddlehurst yes I had at least one person besides Ali tell me that the old link was broken, and we also confirmed with them that this new link works! I agree though - from someone who is already in the slack channel it is hard to tell that the old link doesn't work - one way to tell (I think) is if you try to use the old link in incognito mode you should get the error that new users were experiencing.

On a plus side this new link should "never expire" or at least that is what slack told me when I made it, so hopefully we don't run into this problem again.

@hadifawaz1999
Copy link
Contributor Author

@MatthewMiddlehurst yes I actually tried the link for the first time and did not work for me but it did using the new link that was provided to me. Before adding the new link I noticed that the old one is working for me now (after that I have joined the slack) so I tested it in a FireFox private tab and it did not work, such as @miraep8 explained. After adding the new one I tested it and it works.

@miraep8 miraep8 merged commit 40c10e0 into sktime:main Nov 11, 2022
@fkiraly
Copy link
Collaborator

fkiraly commented Nov 11, 2022

🎉 , welcome @hadifawaz1999 !

@hadifawaz1999
Copy link
Contributor Author

Thank you @fkiraly @miraep8 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Documentation & tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants