[DOC] Regression api #3751
Merged
[DOC] Regression api #3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 10, 2022 13:01
TonyBagnall
requested review from
fkiraly,
aiwalter and
GuzalBulatova
as code owners
MatthewMiddlehurst
added
documentation
MatthewMiddlehurst
previously approved these changes
Nov 11, 2022
There was a problem hiding this comment.
API changes are done in the style of #3742. Should probably wait for that first, but I approve of the changes.
MatthewMiddlehurst
suggested changes
Nov 15, 2022
MatthewMiddlehurst
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This adds CNNRegressor, TapNetRegressor and RocketRegressor to the regression api. I have also expanded the docstring for TapNetRegressor to be a bit more descriptive and added and init to the regression.deep_learning package. CNNRegressor and TapNetRegressor should be private, but that would require deprecation, and is beyond the scope of this [DOC] PR.