Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

& RikStarmans [BUG] fix ColumnEnsembleForecaster for hierarchical X #3768

Merged
merged 4 commits into from
Nov 12, 2022

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Nov 11, 2022

Fixes #3764, with the fix proposed by @RikStarmans (with a minimal change)

Includes the failure case in #3764 as a test.

@fkiraly fkiraly added module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting bugfix Fixes a known bug or removes unintended behavior labels Nov 11, 2022
Copy link
Contributor

@GuzalBulatova GuzalBulatova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, all tests pass

@fkiraly fkiraly merged commit 01b9324 into main Nov 12, 2022
@fkiraly fkiraly deleted the fix-columnensemble-hierarchicalX branch November 12, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug or removes unintended behavior module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ColumnEnsembleForecaster fails with hierarchical exogenous data
2 participants