Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] fixed rendering in dependencies doc #3846

Merged
merged 4 commits into from Dec 1, 2022
Merged

[DOC] fixed rendering in dependencies doc #3846

merged 4 commits into from Dec 1, 2022

Conversation

templierw
Copy link
Contributor

Reference Issues/PRs

Fixes #3421

What does this implement/fix? Explain your changes.

  • Modified introductory sentence with simple enumeration of types;
  • Merge the three note blocks into one that uses a list for explaining the types;
  • less redundant phrasing

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • I've added unit tests and made sure they pass locally.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.

@MatthewMiddlehurst
Copy link
Contributor

I like the style change, though it does not appear to be rendering as intended.

image

You can check out the change by clicking details on the docs/readthedocs.org:sktime test.

@MatthewMiddlehurst MatthewMiddlehurst added the documentation Documentation & tutorials label Nov 28, 2022
@templierw
Copy link
Contributor Author

@MatthewMiddlehurst , I couldn't find "details on the docs/readthedocs.org:sktime test". Is it in the repository?

@achieveordie
Copy link
Collaborator

@templierw You can check out the built doc here.

This is present on this page itself, the last check docs/readthedocs.org:sktime.

@lmmentel
Copy link
Contributor

@templierw FYI
image

Copy link
Contributor

@GuzalBulatova GuzalBulatova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the style change, looks like it's being rendered correctly now, nice work!

@GuzalBulatova GuzalBulatova merged commit a317ffa into sktime:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation & tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Broken rendering of html docs in developer documentation
5 participants