New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] added post-processing notes in tutorial #3878
[DOC] added post-processing notes in tutorial #3878
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That´s nice, thanks!
May I ask for one thing, to keep the repository size small: can you make sure only the parts are changed where you add content?
I think the current huge diff comes from you rerendering plots.
Worst case, this might require going into the ipynb file with an editor, but should also work if you take the original file and copy-paste the change.
@fkiraly I've addressed the proposed changes. The actual diff is visible now. |
also please make sure you run pre-commit bcz linting is failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Great idea to add this content, will be useful to our users!
Change requests:
- linting
- I would split the content and introduce it step by step, or it may be confusing if it comes all at once, see suggestion above
@fkiraly I've rephrased the paragraphs into three sections like you suggested. Linting is working now. Let me know if you find it ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! Just made some minor changes in formatting.
Reference Issues/PRs
Description of PR