Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix soft dependency check in plotting.plot_correlations #3887

Merged
merged 1 commit into from Dec 19, 2022
Merged

[BUG] fix soft dependency check in plotting.plot_correlations #3887

merged 1 commit into from Dec 19, 2022

Conversation

dsanr
Copy link
Contributor

@dsanr dsanr commented Dec 5, 2022

packages must be str or a tuple of str. So, removing additional parenthesis.

packages must be str or a tuple of str. So, removing additional parenthesis.
@dsanr dsanr changed the title Update plotting.py [BUG] Update plotting.py Dec 5, 2022
Copy link
Contributor

@GuzalBulatova GuzalBulatova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, thanks @dsanr !

@dsanr
Copy link
Contributor Author

dsanr commented Dec 8, 2022

@fkiraly and @aiwalter, Could you please check this pull request?

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straightforward bugfix, thanks!

@fkiraly fkiraly changed the title [BUG] Update plotting.py [BUG] fix soft dependency check in plotting.plot_correlations Dec 19, 2022
@fkiraly fkiraly merged commit 9cc5e56 into sktime:main Dec 19, 2022
@dsanr dsanr deleted the patch-1 branch December 19, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants