[ENH] Add colors argument to plot_series
#3908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillerobscuro
requested review from
fkiraly,
aiwalter and
GuzalBulatova
as code owners
GuzalBulatova
approved these changes
Dec 14, 2022
Closed
Thanks Guzal, I'm already on the list and this feature works as expected, at least for me. |
fkiraly
approved these changes
Dec 19, 2022
fkiraly
changed the title
colors argument to plot_series
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to
plot_series()to allow the user to pass a list of colors. I added a small util function to check that the length is correct, and usefrom matplotlib.colors import is_color_liketo check that they are all valid colors. If either condition is not met, then it emits a warning and defaults back to the current behavior, which is usingsns.color_palette("colorblind", n_colors=n_series).