New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] DummyRegressor
for time series regression
#3968
Conversation
Nice! I've started the CI. |
linting is failing, kindly ensure you format your code correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(see above)
Hi, I've gone ahead and fixed the linting issues on my last pull request. I believe everything should be good to go now. Thank you! |
Tests are now genuinely failing. I think this may be one or both fo the following reasons:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot, useful!
there are some small fiddly issues to sort out, see the failing tests
I've gone ahead and fixed the unit test related errors. Code should now be able to pass the tests. |
Nice, they pass now! Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
I made a minor change: put the docs section in alphabetical order
DummyRegressor
for time series regression
Reference Issues/PRs
Fixes #3899.
What does this implement/fix? Explain your changes.
Adds a DummyRegressor that wraps over a sklearn DummyRegressor and inherits from BaseRegressor.
Does your contribution introduce a new dependency? If yes, which one?
No.
PR checklist
For all contributions