[BUG] fix tag logic in AggrDist and FlatDist
#3971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:distances&kernels
fkiraly
added a commit
that referenced
this pull request
Dec 25, 2022
This PR adds a kernel support vector classifier for time series kernels. The added estimator is an interface connector which ties together the `sklearn` support vector classifier and the `sktime` interface for time series distances and kernels. Includes: * #3956 which provides an example of an `sklearn` based kernel function. * #3971 which fixes bugs with `FlatDist` used internally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes erroneous tag logic in
AggrDistandFlatDist:"capability:unequal_length"tag ofFlatDistshould beFalse, as the compositor flattens the time series to a 2Dnumpyarray (with equal length rows). ForAggrDist, it is correctly set asTrue, as the aggregated distance does not assume equal length."capability:missing_values"of bothAggrDistandFlatDistshould be set to the same as the wrapped tabular pairwise transformer.