Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] address pd.Series constructor dtype deprecation / FutureWarning #4031

Merged
merged 2 commits into from Jan 10, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Dec 31, 2022

This PR addresses the FutureWarning deprecation message received from pandas for one instance of pd.Series constructor with dtype not explicitly set.

The fix is setting the dtype explicitly, which resolves the deprecation message in case the resulting series is empty.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Dec 31, 2022
@fkiraly fkiraly merged commit 865c88d into main Jan 10, 2023
@fkiraly fkiraly deleted the pandas-deprec-message branch January 10, 2023 11:43
@fkiraly fkiraly changed the title [MNT] address pd.Series constructor dtype deprecation [MNT] address pd.Series constructor dtype deprecation / FutureWarning Jan 11, 2023
klam-data pushed a commit to CodeSmithDSMLProjects/sktime that referenced this pull request Jan 18, 2023
This PR addresses the deprecation message received from `pandas` for one instance of `pd.Series` constructor with `dtype` not explicitly set.

The fix is setting the `dtype` explicitly, which resolves the deprecation message in case the resulting series is empty.
fkiraly added a commit that referenced this pull request Jan 21, 2023
…rning` - part 2 (#4111)

This PR addresses the `FutureWarning` deprecation message received from `pandas` for one instance of `pd.Series` constructor with `dtype` not explicitly set.

The fix is setting the `dtype` explicitly, which resolves the deprecation message in case the resulting series is empty.

Same as the fix in #4031, but for another splitter - I unfortunately did not spot the second instance here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant