New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Implementing plot title for plot_series
#4038
Conversation
Hey @arnavrneo, this looks like a nice new feature! Is it necessary to use Either way I'd suggest calling the argument |
@chillerobscuro Thanks! About
|
Only difference I can see is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a pretty straightforward change and it works for me. Congrats on making your first contribution @arnavrneo Will merge tomorrow as long as there are no other change requests in the mean time! You are also welcome/encouraged to add yourself to the list of contributors! :)
Thanks! |
Hey @arnavrneo - congrats on making your first contribution to sktime! Apologies I merged this before you were properly added as a contributor, and I am sorry for not answering your questions before! In short - yes - you can add yourself to that document! :) You can either: a) do it yourself in a new PR, b) tack it on to your next PR to sktime or c) I can add you for you! :) Welcome to sktime again! :) 🎉 🎉 🎉 |
Reference Issues/PRs
Fixes #3944
What does this implement/fix? Explain your changes.
This implementation updates
plotting.py
underutils
directory. The functionplot_series
is updated and now the user can enter the plot title for the figure.Changes:
plot_series
now has one more parameter:suptitle
(default value isNone
) to which user can give the title of the plot or figure.Does your contribution introduce a new dependency? If yes, which one?
No.
PR checklist
For all contributions
⬜ I've added myself to the list of contributors.
✅ I've added unit tests and made sure they pass locally.
✅ The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.