[MNT] downwards compatibility fixes for minimal dependency set #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
the
maintenance
klam-data
pushed a commit
to CodeSmithDSMLProjects/sktime
that referenced
this pull request
Jan 18, 2023
…e#4041) This PR contains downwards compatibility fixes for the minimal version dependency set currently supported by `sktime`. Because CI was not testing for minimal version dependencies, there have been punctual divergences in compatibility with the minimal dependency set. This PR aims to fix this. PR sktime#4016 introduces a CI element to test on the minimal dependency set, against which the fixes in this PR are developed. Fixes: * old `sklearn` versions require an experimental enablement flag for use of `HistGradientBoostingRegressor`. The fix is to include that flag conditional on `sklearn` version. * the `DateTimeFeatures` transformer depends on `pandas` `DatetimeProperties` which is only available in its current form since `pandas 1.2.0`. The fix is to include this as a dependency requirement in the estimator and isolate the tests conditionally. Depends on: * sktime#4044 as PEP 440 specifiers are introduced in estimator dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains downwards compatibility fixes for the minimal version dependency set currently supported by
sktime.Because CI was not testing for minimal version dependencies, there have been punctual divergences in compatibility with the minimal dependency set. This PR aims to fix this.
PR #4016 introduces a CI element to test on the minimal dependency set, against which the fixes in this PR are developed.
Fixes:
sklearnversions require an experimental enablement flag for use ofHistGradientBoostingRegressor. The fix is to include that flag conditional onsklearnversion.DateTimeFeaturestransformer depends onpandasDatetimePropertieswhich is only available in its current form sincepandas 1.2.0. The fix is to include this as a dependency requirement in the estimator and isolate the tests conditionally.Depends on:
_check_soft_dependenciesbreaking for PEP 440 specifiers without class reference #4044 as PEP 440 specifiers are introduced in estimator dependencies