[ENH] Speed up hierarchical checks and unify with panel approach #4061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbartl
requested review from
fkiraly,
aiwalter and
GuzalBulatova
as code owners
fkiraly
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
brilliant!
Yes, I have also noticed this when I was working on dask and applied the same pattern: #4011
Overall, I think it may make sense to move panel/hierarchical closer long-term, perhaps even looking at a merge.
The problem is that there are some mtypes that do not clearly generalize to hierarchical, which are in use primarily in the "panel" based tasks like time series classification, e.g., 3D numpy array (although one could say, nD for n>3 means hierarchical).
At least currently that implies that panel needs to be treated separately. If it were only frames, I would fully agree that panel and hierarchical scitypes could be merged.
fkiraly
added
module:datatypes
klam-data
pushed a commit
to CodeSmithDSMLProjects/sktime
that referenced
this pull request
Jan 18, 2023
Roll out of panel datatype check changes to hierarchical datatype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll out of #3935 to hierarchical checks.
Also unified the approach here, since in my view checks should use the same functions (essentially panel and hierarchical are just variations of each other)