Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] fix nlag logic in SeasonalityACF and SeasonalityACFqstat #4171

Merged
merged 1 commit into from Feb 4, 2023
Merged

[BUG] fix nlag logic in SeasonalityACF and SeasonalityACFqstat #4171

merged 1 commit into from Feb 4, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Jan 29, 2023 •
edited

Fixes #4169, by correcting the range expression, and clarifying the docstring.

@fkiraly fkiraly added bugfix Fixes a known bug or removes unintended behavior module:parameter-estimators parameter fitters and estimators labels Jan 29, 2023
@fkiraly fkiraly mentioned this pull request Jan 29, 2023
Closed
ngupta23
ngupta23 reviewed Jan 29, 2023
View reviewed changes
Copy link
Contributor

@ngupta23 ngupta23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @fkiraly . Thanks!

@fkiraly fkiraly merged commit 87b9444 into main Feb 4, 2023
@fkiraly fkiraly deleted the acf-lags-default branch February 4, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngupta23 ngupta23 ngupta23 approved these changes

Assignees
No one assigned
Labels
bugfix Fixes a known bug or removes unintended behavior module:parameter-estimators parameter fitters and estimators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] SeasonalityACF nlags is not inclusive
2 participants
@fkiraly @ngupta23