[BUG] AutoETS, UnobservedComponents: fix predict_interval for integer based index not starting at zero
#4180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:forecasting
fkiraly
changed the title
AutoETS._predict_interval for integer based index not starting at zeroAutoETS, UnobservedComponents: fix predict_interval for integer based index not starting at zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4173, the index generation in
AutoETSandUnobservedComponentswas wrong.Also extends the
test_predict_intervalto test integer based indices (the default_make_seriesoutput starts at 3, not 0).This covers the fix - it has also highlighed the same buggy behaviour in
SquaringResidualswhich seems to have a different cause.As this is a different bug, it has been added to the bug tracker here #4181, and is excepted from tests temporarily.