Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix race condition in tsfile tests #4192

Merged
merged 1 commit into from Feb 4, 2023

Conversation

hoesler
Copy link
Contributor

@hoesler hoesler commented Feb 3, 2023

Reference Issues/PRs

Split out of #4140

What does this implement/fix? Explain your changes.

This fixes a race condition in tests, if run in parallel. The "./Temp" dir might get deleted while another test is relying on its presence. This fix replaces the explicit creation of a temp dir with a fixture, unique to each test execution.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@hoesler hoesler requested a review from fkiraly as a code owner February 3, 2023 09:23
@hoesler hoesler mentioned this pull request Feb 3, 2023
5 tasks
@fkiraly fkiraly added bugfix Fixes a known bug or removes unintended behavior module:datasets&loaders data sets and data loaders module:tests test framework functionality - only framework, excl specific tests labels Feb 3, 2023
@fkiraly fkiraly changed the title [BUG] fix race condition in tsfile tests [BUG] fix race condition in tsfile tests Feb 3, 2023
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

Would you mind quickly checking whether this is any of these reported sporadic bugs?
https://github.com/sktime/sktime/issues?q=is%3Aissue+is%3Aopen+sporadic

@fkiraly fkiraly merged commit 047d544 into sktime:main Feb 4, 2023
@hoesler hoesler deleted the fix-pytest-race-condition branch February 6, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug or removes unintended behavior module:datasets&loaders data sets and data loaders module:tests test framework functionality - only framework, excl specific tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants