Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] nullable dtypes - ensure nullable columns are coerced to float dtype in pandas conversions #4245

Merged
merged 10 commits into from Mar 14, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Feb 18, 2023

This ensures that pandas objects are coerced to non-nullable float before entering sktime.

Goes towards #2967, and fixes one of the failures of with the diagnostic #2966.

Testing is currently tentative/temporary, via merge into #2966

@fkiraly fkiraly added module:datatypes datatypes module: data containers, checkers & converters enhancement Adding new functionality labels Feb 18, 2023
@fkiraly fkiraly changed the title [ENH] nullable dtypes - ensure float dtype in pandas to numpy coercions [ENH] nullable dtypes - ensure nullable columns are coerced to float dtype in pandas conversions Feb 19, 2023
@fkiraly fkiraly merged commit cd9fe0c into main Mar 14, 2023
@fkiraly fkiraly deleted the df-to-numpy3D-float branch March 14, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality module:datatypes datatypes module: data containers, checkers & converters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant