[MNT] Fixes linting issue B016 Cannot raise a literal in distances module
#4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
previously approved these changes
Mar 4, 2023
fkiraly
added
the
maintenance
|
Hi @fkiraly, is it okay for this PR to get merged? I'm waiting so that I can easily create branches for the fixes in other modules too. |
|
yes, I was just waiting for the tests to pass. |
fkiraly
changed the title
Distances moduleB016 Cannot raise a literal in distances module
SamiAlavi
added a commit
to SamiAlavi/sktime
that referenced
this pull request
Mar 9, 2023
…time#4284) Towards sktime#4182 Fixes linting issue `B016 Cannot raise a literal. Did you intend to return it or raise an Exception?` in `distances` module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#4182
What does this implement/fix? Explain your changes.
Fixed B016 Cannot raise a literal. Did you intend to return it or raise an Exception?
Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
sktime/distances/_ddtw.py:119:13: B016 Cannot raise a literal. Did you intend to return it or raise an Exception?sktime/distances/_ddtw.py:221:13: B016 Cannot raise a literal. Did you intend to return it or raise an Exception?Did you add any tests for the change?
No
Any other comments?
No
PR checklist
For all contributions
For new estimators