&marrov [BUG] fix Settingwithcopywarning when using custom error metric in evaluate
#4294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:forecasting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4292
@marrov, thanks, I think you've correctly identified the source location of the bug!
I'm not quite clear why we are dealing with a
DataFramethat has repeated index (zero??), but I've fixed it now by chaging the chained double access to singlelocaccess with two indices, and ensuring the multiple indexp roblem does not occur.Perhaps @topher-lo has a piece of wisdom to offer what eactly was happening there with the index...