Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Fixes linting issues in base, networks, registry modules #4310

Merged
merged 1 commit into from Mar 12, 2023

Conversation

SamiAlavi
Copy link
Contributor

Reference Issues/PRs

#4182

What does this implement/fix? Explain your changes.

  • Fix B028 No explicit stacklevel keyword argument found

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

  • B028 No explicit stacklevel keyword argument found

Did you add any tests for the change?

No

Any other comments?

No

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

Recommended to use a stacklevel of 2 or greater to provide more
information to the user
@SamiAlavi SamiAlavi requested a review from fkiraly as a code owner March 9, 2023 18:56
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, the second!

@fkiraly fkiraly merged commit 66c437a into sktime:main Mar 12, 2023
@SamiAlavi SamiAlavi deleted the mnt_sklearn_base_networks_registry branch March 12, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants