Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Fix linting issues in performance_metrics module #4320

Merged
merged 2 commits into from Mar 15, 2023
Merged

[MNT] Fix linting issues in performance_metrics module #4320

merged 2 commits into from Mar 15, 2023

Conversation

SamiAlavi
Copy link
Contributor

Reference Issues/PRs

#4182

What does this implement/fix? Explain your changes.

  • isort auto-fixes
  • Fix pydocstyle issues (D100, D400, D103)

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

  • isort auto-fixes
  • pydocstyle issues (D100, D400, D103)

Did you add any tests for the change?

No

Any other comments?

No

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@SamiAlavi SamiAlavi requested a review from fkiraly as a code owner March 13, 2023 16:41
fkiraly
fkiraly requested changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you kindly replace the full names by GitHub names at the top of the module (otherwise the contributions are not auto-linked)

fkiraly
fkiraly approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed with suggestion to cover GitHub names in separate PR, GitHub name replacement is scope creep.

Could you kindly open an issue to track that?

@SamiAlavi
Copy link
Contributor Author

Created issue #4335 to track updating author names

@fkiraly fkiraly merged commit 0119386 into sktime:main Mar 15, 2023
20 checks passed
@SamiAlavi SamiAlavi deleted the mnt_sktime_performance_metrics branch March 15, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkiraly fkiraly fkiraly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SamiAlavi @fkiraly