Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Fix linting issues in utils module #4322

Merged
merged 4 commits into from Mar 15, 2023

Conversation

SamiAlavi
Copy link
Contributor

Reference Issues/PRs

#4182

What does this implement/fix? Explain your changes.

  • isort auto-fixes
  • Ignore flake8 issue (B023 Function definition does not bind loop variable)
  • Fix pydocstyle issues (D100, D103, D104)
  • Fix flake8 issues (B028)

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

  • isort auto-fixes
  • flake8 issue (B023 Function definition does not bind loop variable)
  • pydocstyle issues (D100, D103, D104)
  • flake8 issues (B028)

Did you add any tests for the change?

No

Any other comments?

No

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@SamiAlavi SamiAlavi requested a review from fkiraly as a code owner March 13, 2023 16:45
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Highlighted issue looks indeed like false alarm.

@fkiraly fkiraly merged commit 5f1f401 into sktime:main Mar 15, 2023
20 checks passed
@SamiAlavi SamiAlavi deleted the mnt_sktime_utils branch March 15, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants