[BUG] fix seasonality estimators for candidate_sp being int
#4360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
bugfix
|
Factored out of #4248 which was open for a while |
fkiraly
added a commit
that referenced
this pull request
Mar 19, 2023
See #4249 This adds a transformer compositor which executes a transform conditionally, e.g., deseasonalizes if seasonality is detected, or differences if stationarity is detected. The condition can be specified flexibly based on any estimator (with a `fit` interface), and the if/else transformation can also be configured. Relies on #4360 for the seasonality example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an unreported bug when
candidate_spin two seasonality estimators would beint. According to the docstring, this should be treated as a one-element iterable, but instead led to error.This is fixed by coercing to one-element iterable, and covered by an additional test case.
The estimators concerned are
SeasonalityACFandSeasonalityACFqstat.