[MNT] remove soft dependency import warnings in modules and documented requirements to add these #4398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, modules that contained objects with soft dependencies were raising import warnings.
This would raise a lot of warnings in crawling based utilities such as
all_estimators
(and cause those utilities to have a longer runtime than otherwise).In many cases, the warnings would be raised without a clear reason visible to the user, and would confuse more than they would help - contributing to some user frustration.
The information is still raised as an error when users try to construct the estimators in question - and there cause and effect are much clearer. Therefore, I would argue that it is an improvement to get rid of the module warnings.
This PR removes both the existing warnings in estimator modules and the convention itself:
_check_soft_dependencies
with warning level at module import, in estimator modules