[MNT] address deprecation of automatic drop on DataFrame.agg on non-numeric columns
#4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
maintenance
fkiraly
added a commit
that referenced
this pull request
Apr 10, 2023
Fixes #4426. This PR contains some tentative fixes for compatibility issues arising from the `pandas` 2 release on Apr 3: * fixes to index handling in `ForecastingHorizon.to_absolute` * fixes to many instances of using `ForecastingHorizon` as `pd.DataFrame` `index` in constructor or setter (`.index = ...`), this is no longer possible * writing to a `loc` index that does not exist no longer creates it but raises an exception - this was replaced by ensuring the right rows and columns are present before the write - `AutoETS`, `UnobservedComponents` * replace deprecated `is_integer` and `is_numeric` with recommended replacement calls to `pandas.api.types` * fixed old `from_nested_to_multi_index` utility producing `object` valued multiindex (instead of integer typed etc) * same for `_convert_tsf_to_hierarchical` utility in data loaders * replace deprecated `pandas.util.testing` imports with `pandas.testing` * #4435 * #4436 * replace in-place nested pandas operations with construction of new frame: `test_interpolate` * #4438 * replace single-index temporal slicing at lower granularity with slice-based slicing Relies on #4429 for testing. Does *not* change the dependency bounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to
pandas 2,DataFrame.aggwould automatically drop non-numeric columns for numeric aggregations.That is no longer the case from
pandas 2and causes exceptions.This PR addresses the deprecation by manually dropping respective columns.