Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] fix and sharpen soft dependency isolation logic for statsmodels and pmdarima #4443

Merged
merged 5 commits into from Apr 10, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Apr 7, 2023

This fixes and sharpens a number of soft dependency isolations.

  • supersedes some incorrect soft isolation statements with the below. E.g., the run condition for some tests involving ARIMA was statsmodels present, while ARIMA requires pmdarima. This may not have been spotted since pmdarima requires statsmodels, and users of statsmodels might often have pmdarima installed.
  • replaces all pmdarima isolation statements with _check_estimator_deps statements, which is clearer to read as it relates directly to the estimator.
  • same for all statements affecting ARDL
  • sharpens the dependency tag of ARDL from statsmodels to statmodels>=0.13.0

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Apr 7, 2023
@fkiraly fkiraly changed the title [MNT] replace wrong soft dependency in test isolation statement [MNT] fix and sharpen soft dependency isolation logic Apr 7, 2023
@fkiraly
Copy link
Collaborator Author

fkiraly commented Apr 10, 2023

0.17.1 scheduled for early release due to #4449, adding this too (dep isolation)

@fkiraly fkiraly changed the title [MNT] fix and sharpen soft dependency isolation logic [MNT] fix and sharpen soft dependency isolation logic for statsmodels and pmdarima Apr 10, 2023
@fkiraly fkiraly merged commit 54f4326 into main Apr 10, 2023
22 checks passed
@fkiraly fkiraly deleted the wrong-softdep-isolate branch April 10, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant