[ENH] allow inclusive/exclusive bounds in get_slice
#4483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:datatypes
fkiraly
added a commit
that referenced
this pull request
Apr 21, 2023
…s than forecasting horizon (#3667) Fixes #3657. The bug was caused by `pmdarima` models breaking when the `X` passed was strictly larger than the indices in the forecasting horizon. The example code in #3657 has been added as a test (with minor generalization to cover more estimators). In the future, we should probably also add test scenarios where `X` is strictly larger than the forecasting horizon. Depends on: * #4474, which fixes a bug that was masked by #3657 * #4483 for slicing `X`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two arguments to
get_sliceto allow exclusive/inclusive bounding at either and of the slice.The default of the two new arguments leads to current behaviour, so no deprecation is necessary.
This will be useful as a utility, and also for fixing #3667