Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix error in MiniRocket example code - wrong transformer #4497

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

doncarlos999
Copy link
Contributor

@doncarlos999 doncarlos999 commented Apr 21, 2023

Error in MiniRocket example code

Reference Issues/PRs

Fixes error in MiniRocket example code

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

No new dependencies

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

Error in MiniRocket example code
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Didn't spot that.

@fkiraly fkiraly changed the title Fix error in MiniRocket example code [BUG] Fix error in MiniRocket example code - wrong transformer Apr 21, 2023
@fkiraly fkiraly merged commit b54f54a into sktime:main Apr 21, 2023
21 checks passed
@fkiraly fkiraly added documentation Documentation & tutorials module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing labels Apr 21, 2023
@fkiraly fkiraly changed the title [BUG] Fix error in MiniRocket example code - wrong transformer [DOC] Fix error in MiniRocket example code - wrong transformer Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation & tutorials module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants