-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] changing Union[int | float] to float as per issue #4379 #4575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There are a lot of other occurrences of Union[int, float]
, so it would be great if you could also take care of those - simply use vs code or pycharm search all files functionality.
Will make the necessary changes |
I think these are the only occurrences of |
Yes, I think you got all of them, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Reference Issues/PRs
Fixes #4379
in type annotations, replaces all instances of
Union[int | float]
(either way round) withfloat
What does this implement/fix? Explain your changes.
This is my first contribution.
replacing Union[int | float] to just float