Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update link in minirocket.ipynb #4577

Merged
merged 1 commit into from May 12, 2023
Merged

Conversation

panozzaj
Copy link
Contributor

Reference Issues/PRs

N/A

What does this implement/fix? Explain your changes.

One of the links in the MiniRocket notebook was pointing at a file that doesn't seem to exist, and I found one that is similarly named and seems to have relevant content.

Does your contribution introduce a new dependency? If yes, which one?

No.

What should a reviewer concentrate their feedback on?

Does this link seem right?

Did you add any tests for the change?

N/A

Any other comments?

No.

PR checklist

For all contributions
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.

Was pointing at a file that doesn't seem to exist, and I found one that is similarly named and seems to have relevant content.
@panozzaj panozzaj requested a review from fkiraly as a code owner May 11, 2023 21:37
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the right link, thanks!

Feel free to add yourself to the contributors file with a doc badge.

@fkiraly fkiraly merged commit 58f02fd into sktime:main May 12, 2023
23 checks passed
@panozzaj
Copy link
Contributor Author

Thanks for the quick review. If I make a more substantive change, will try to add to contributors. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants