Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] fix warnings in make sphinx - language (conf.py) and dists_kernels.rst wrong imports #4593

Merged
merged 2 commits into from May 16, 2023
Merged

[ENH] fix warnings in make sphinx - language (conf.py) and dists_kernels.rst wrong imports #4593

merged 2 commits into from May 16, 2023

Conversation

mdsaad2305
Copy link
Contributor

@mdsaad2305 mdsaad2305 commented May 16, 2023 •
edited by fkiraly

Fixes warnings in make sphinx:

  • changed language = None to language = "en"
  • fixing import errors in conf.py

@mdsaad2305 mdsaad2305 requested a review from fkiraly as a code owner May 16, 2023 17:19
@mdsaad2305 mdsaad2305 changed the title made changes to confy.py and dists_kernels.rst [ENH] made changes to confy.py and dists_kernels.rst May 16, 2023
@fkiraly fkiraly changed the title [ENH] made changes to confy.py and dists_kernels.rst [ENH] fix warnings in make sphinx - language (conf.py) and dists_kernels.rst wrong imports May 16, 2023
fkiraly
fkiraly approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The failures are unrelated, due to #4594

@fkiraly fkiraly merged commit e28acd5 into sktime:main May 16, 2023
23 checks passed
@mdsaad2305 mdsaad2305 deleted the bug-fixing branch May 16, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkiraly fkiraly fkiraly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdsaad2305 @fkiraly