New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] adding doctest guide to the testing documentation #4634
Conversation
Should I make any additional changes to the file to pass the code-quality section? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Some small requests:
- linting fails in this PR, please fix that
- can you say explicitly how to run all doctests in
sktime
?
Hey, just needed some help before I implement these changes.
|
If you follow the link to "coding standards" on the page you are editing, I hope you'll find a guide that's explicit about this.
Yes, that's what I meant, thanks for asking. |
Could you let me know if the code for running all the files is correct? It seems to be working fine for me, but I hope I don't end up confusing the newcomers. |
Hm, I would have done |
Might be an issue with my system but does using pytest normally take a long time? |
is this alright? |
So, my suggestion is to include ways to run with both, and specify that one can try with the |
Ah, I see - should we then mention both |
Exactly. @mdsaad2305: can you also try to find a similar command for Windows users? It'll be good to document as well along with @fkiraly's above summary, if possible. |
Sure, I’ve some work till Friday, so I’ll try to finish it during the weekend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks, great compilation!
Reference Issues/PRs
Fixes #4582
What does this implement/fix? Explain your changes.
Included doctest documentation within the testing and continuous integration section.