Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] remove private imports from sklearn - set_random_state #4672

Merged
merged 4 commits into from Jun 10, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Jun 3, 2023

Towards #4670

Eliminates private imports from sklearn:

  • set_random_state and _set_random_states imports replaced by an sktime local set_random_state (consensus replacement)
  • fixes an unreported bug where internal random state seeds could under some conditions exceed the max permissible in numpy, of 2**32 -1

Todo:

  • _partition_estimators imports
  • from sklearn.ensemble._forest import-s

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Jun 3, 2023
@ngupta23
Copy link
Contributor

ngupta23 commented Jun 8, 2023

@fkiraly - anything blocking this PR?

@fkiraly
Copy link
Collaborator Author

fkiraly commented Jun 8, 2023

anything blocking this PR?

No, just the usual 7 day lazy acceptance period if no one reviews it.

@fkiraly fkiraly merged commit 045affb into main Jun 10, 2023
27 of 28 checks passed
@fkiraly fkiraly deleted the no-sklearn-private branch June 10, 2023 17:01
@fkiraly fkiraly changed the title [MNT] remove private imports from sklearn [MNT] remove private imports from sklearn - set_random_state Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants