Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] resolve pre-commit issues on main #4673

Merged
merged 3 commits into from Jun 4, 2023
Merged

[MNT] resolve pre-commit issues on main #4673

merged 3 commits into from Jun 4, 2023

Conversation

yarnabrina
Copy link
Collaborator

Running pre-commit on main branch finds a few linting issues. These are probably introduced because of old PR's before adding the linters, or because of some skipped CI's. This PR attempts to solve these.

Steps followed:

  1. Ran pre-commit run --all-files on main branch.
  2. Got 3 issues regarding misisng module docstring, trailing whitespace and missing newline.
  3. Fixed one by one.

@yarnabrina yarnabrina requested a review from fkiraly as a code owner June 4, 2023 06:05
@yarnabrina
Copy link
Collaborator Author

A related note is that most hook versions in .pre-commit-config.yaml is outdated. If updated to latest versions using pre-commit autoupdate, it leads to changes to ~140 files, and a lot of file blame will be modified. Skipped for now, but this may be worth considering in future.

@fkiraly fkiraly added documentation Documentation & tutorials maintenance Continuous integration, unit testing & package distribution labels Jun 4, 2023
@fkiraly
Copy link
Collaborator

fkiraly commented Jun 4, 2023

Skipped for now, but this may be worth considering in future.

I would recommend, open an issue with the "maintenance" tag

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

odd that nothing complained when we merged these, some of these files were changed recently.

@fkiraly fkiraly merged commit 678fc18 into sktime:main Jun 4, 2023
28 checks passed
@yarnabrina yarnabrina deleted the run-pre-commit branch June 4, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation & tutorials maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants