New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added matrix profile using stumpy #471
Conversation
As a next step, take a look at the |
I checked out |
@utsavcoding in order to get the unit tests to pass you need to add it in |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @utsavcoding, in order to get the unit tests to pass you need to add it in build_tools/requirements.txt
and in setup.py
extra requirements. If you want to add a tutorial notebook later on, you also have to add it in .binder/requirements.txt
.
Let me know if you need help with that, I don't see the error that you see at the moment because stumpy isn't installed because it is not specified in the requirements.
FYI we had some CI issues, but they're now fixed on master, so you need to update your branch with the latest changes on master. |
@mloning I have synced my local master branch with the latest updates. And I have added the dependency in as per mentioned above, but I am still facing a key error issue due to which 2 of the pytest(test_all_estimators.py, test_all_transformers.py) are failing. |
FYI your master was still out-of-sync (see my latest commit), I'm going to take a look over the next few days! |
matrix_profile.py with soft dependency check for stumpy only
Matrix Profile transformer for dataframe
d73a481
to
9b498a8
Compare
@mloning I have pushed in the changes with default window_length=3 for matrix profile. Can you please review it. |
@mloning Added configuration for stumpy in check_soft_dependencies.py(failure of azure build in github). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @utsavcoding, all tests pass, everything looks good to me! I'll leave it open a bit longer in case others want to comment before we merge.
Thanks again @utsavcoding - great work! |
matrix_profile.py with soft dependency check for stumpy added
Reference Issues/PRs
#450
What does this implement/fix? Explain your changes.
Interface and wrap stumpy.stump in series-to-series transformer.
Does your contribution introduce a new dependency? If yes, which one?
No hard dependency, but stumpy is introduced as soft dependency
PR checklist
For all contributions
For new estimators
Any other comments?