&yarnabrina [BUG] correct ForecastX behaviour in case of multivariate y
#4719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:forecasting
fkiraly
changed the title
ForecastX behaviour in case of multivariate yForecastX behaviour in case of multivariate y
yarnabrina
approved these changes
Jun 19, 2023
|
The error in
I suppose this can be ignored? Only happened on this specific job, others ran fine. |
Not sure - could be a 3.7 issue. |
CTFallon
pushed a commit
to CTFallon/sktime
that referenced
this pull request
Jun 21, 2023
…te `y` (sktime#4719) For multivariate `y`, the compositor `ForecastX` would always broadcast over variables of `y`, even if wrapped forecasters were multivariate. However, `ForecastX` itself should never broadcast over `y`, that should be left to component forecasters. Fixed here, this also fixes sktime#4718 Includes a slightly extended test case from the bug report sktime#4718 by @yarnabrina
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For multivariate
y, the compositorForecastXwould always broadcast over variables ofy, even if wrapped forecasters were multivariate.However,
ForecastXitself should never broadcast overy, that should be left to component forecasters.Fixed here, this also fixes #4718
Includes a slightly extended test case from the bug report #4718 by @yarnabrina