[MNT] Temporarily skip all DL Estimators #4760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
reviewed
Jun 25, 2023
| @@ -37,6 +37,13 @@ | |||
| "SimpleRNNClassifier", | |||
| "SimpleRNNRegressor", | |||
| "EditDist", | |||
There was a problem hiding this comment.
I notice, EditDist is not a DL estimator - do we want to remove it from the list or write a separate comment?
fkiraly
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
In reference to #4610, skipping all DL estimators that are causing several CI runs to crash till we find a root cause and hence a solution to this.