[ENH] improvements to _ColumnEstimator - refactor to reduce coupling with BaseForecaster
#4791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
enhancement
fkiraly
changed the title
_HeterogenousMetaEstimator and _ColumnEstimator_ColumnEstimator - refactor to reduce coupling with BaseForecaster
fkiraly
requested review from
achieveordie,
benHeid and
yarnabrina
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the
_HeterogenousMetaEstimatorand_ColumnEstimator:_HeterogenousMetaEstimatornow allows tuples of any length in the_steps_attr, as long as the zeroth elements are str names, and the first elements are estimators_ColumnEstimator._coerce_to_pd_indexhas been refactored so that arefreference index is passed instead of assumingself._yis present (which is the case only in forecasters)The change to
_HeterogenousMetaEstimatoris indirectly tested in #4789 and will be tested inscikit-base.The change to
_ColumnEstimator._coerce_to_pd_indexis covered by existing tests as it is a re-factor that makes it more flexible (allowing #4789).Depends on #4789 (and therefore indirectly on #4793)