[BUG] Add temporary fix to _BaseWindowForecaster to handle simultaneous in and out-of-sample forecasts #4812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2023 08:48
…mple and outofsample forecasts
fkiraly
added
module:forecasting
fkiraly
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added temporary fix to _BaseWindowForecaster to handle simultaneous in and out-of-sample forecasts (see #4773). Also added a test to check if NaiveForecaster and BaseWindowForecaster work as expected.
Reference Issues/PRs
Fixes #4773
What does this implement/fix? Explain your changes.
Added an if clause to _BaseWindowForecaster _predict method to correctly concatenate the outputs of in and out of sample forecasts.
Does your contribution introduce a new dependency? If yes, which one?
No
Did you add any tests for the change?
Added
test_insample_and_outofsample_forecastingtosktime/forecasting/tests/test_window_forecasters.pyAny other comments?
As this is my first contribution to this package, I'm not sure if I'm skipping some name or other convention. Please feel free to highlight if something should be altered in this PR.