[MNT] remove forgotten deprecated import from 0.13.0
#4824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
the
maintenance
fkiraly
added a commit
that referenced
this pull request
Aug 18, 2023
…e in 0.22.0 (#4822) In the spirit of minimizing dependencies, I suggeste to deprecate (0.21.0 or 0.20.1) and then remove the `deprecated` package as a dependency. We haven't used `deprecated` for deprecations in a while, especially since interfaces have matured and we rarely deprecate entire classes or functions anymore. Deprecations are still common, but they mostly affect arguments, parameters, or their behaviour instead, cases not covered by the `deprecated` package afaik. Of course, as a current core dependency, we would need to deprecate `deprecated` itself, as a dependency. Following the established procedure, this would be announced as a deprecation in the next release (0.20.1 and/or 0.21.0), and then removed in 0.22.0. Depends on #4824 which removes a forgotten import of `deprecated`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a forgotten, old import of
deprecateddating back to 0.13.0.There was a deprecation action attached which never got carried out, we should revisit this later (so I added a todo with the next MINOR release instead)